Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for cuda-python 12.0.0 / CUDA 12. #33

Merged
merged 34 commits into from
Jun 2, 2023
Merged

Update for cuda-python 12.0.0 / CUDA 12. #33

merged 34 commits into from
Jun 2, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 5, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Drafting this PR early (dependencies not yet ready). Resolves #31. Resolves #32 (replaces the autotick PR).

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bdice
Copy link
Contributor Author

bdice commented Apr 5, 2023

@conda-forge-admin, please rerender

@jakirkham
Copy link
Member

Think we need to add conda_build_config.yaml to the recipe to get the missing pieces

Do we want to do 12.0?

@bdice bdice changed the title Update for cuda-python 12.1.0 / CUDA 12. Update for cuda-python 12.0.0 / CUDA 12. Apr 20, 2023
@bdice
Copy link
Contributor Author

bdice commented Apr 20, 2023

@conda-forge-admin, please rerender

@bdice
Copy link
Contributor Author

bdice commented Apr 20, 2023

Think we need to add conda_build_config.yaml to the recipe to get the missing pieces

Do we want to do 12.0?

Yes and yes. I'm moving in this direction now! 😄

@bdice bdice mentioned this pull request Apr 25, 2023
Closed
jakirkham
jakirkham reviewed May 23, 2023
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
bdice
bdice commented Jun 1, 2023
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor Author

bdice commented Jun 1, 2023

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@bdice
Copy link
Contributor Author

bdice commented Jun 1, 2023

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bdice bdice mentioned this pull request Jun 2, 2023
Merged
5 tasks
This was referenced Jun 2, 2023
Closed
Closed
Closed
@jakirkham jakirkham requested a review from m3vaz June 2, 2023 20:54
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-python-feedstock/actions/runs/5159664135.

@jakirkham jakirkham dismissed m3vaz’s stale review June 2, 2023 20:58

Addressed in discussion, raised issues, & added a comment in the recipe

@jakirkham jakirkham requested review from m3vaz and removed request for m3vaz June 2, 2023 20:59
m3vaz
m3vaz reviewed Jun 2, 2023
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
m3vaz
m3vaz reviewed Jun 2, 2023
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • pin_subpackage should be used instead of pin_compatible for cuda-python because it is one of the known outputs of this recipe: ['cuda-python'].

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham requested a review from m3vaz June 2, 2023 21:12
@bdice
Copy link
Contributor Author

bdice commented Jun 2, 2023

@jakirkham @m3vaz I took a quick look here -- all the recent changes seem good to me (though I can't review my own PR).

m3vaz
m3vaz approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@m3vaz m3vaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Jun 2, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Adding the automerge label so the bot will merge the PR once CI passes 🙂

@github-actions github-actions bot merged commit 8f1cd6b into conda-forge:main Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@mmccarty
Copy link
Contributor

mmccarty commented Jun 2, 2023

Thanks all! Great work!

@jakirkham jakirkham mentioned this pull request Dec 19, 2023
Merged
@jakirkham jakirkham mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang left review comments

@jakirkham jakirkham jakirkham approved these changes

@m3vaz m3vaz m3vaz approved these changes

@mmccarty mmccarty Awaiting requested review from mmccarty mmccarty is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cuda-python: Support CUDA 12
5 participants
@bdice @jakirkham @mmccarty @leofang @m3vaz